-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attached Collision Object Transparency #3093
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oveit2 into collision-object-transparency
rr-aiden
changed the title
Collision object transparency
Attached Collision Object Transparency
Nov 15, 2024
sjahr
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thanks!
sjahr
added
backport-humble
Mergify label that triggers a PR backport to Humble
backport-iron
Mergify label that triggers a PR backport to Iron
labels
Nov 15, 2024
sea-bass
approved these changes
Nov 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 15, 2024
mergify bot
pushed a commit
that referenced
this pull request
Nov 15, 2024
* Allows attached collision objects to be transparent * Allows for config/RViz driven changing of the attached collision object transparency --------- Co-authored-by: Sebastian Jahr <[email protected]> (cherry picked from commit 1944811)
6 tasks
mergify bot
pushed a commit
that referenced
this pull request
Nov 15, 2024
* Allows attached collision objects to be transparent * Allows for config/RViz driven changing of the attached collision object transparency --------- Co-authored-by: Sebastian Jahr <[email protected]> (cherry picked from commit 1944811)
6 tasks
sea-bass
pushed a commit
that referenced
this pull request
Nov 15, 2024
* Allows attached collision objects to be transparent * Allows for config/RViz driven changing of the attached collision object transparency --------- Co-authored-by: Sebastian Jahr <[email protected]> (cherry picked from commit 1944811) Co-authored-by: Aiden <[email protected]>
sea-bass
pushed a commit
that referenced
this pull request
Nov 16, 2024
* Allows attached collision objects to be transparent * Allows for config/RViz driven changing of the attached collision object transparency --------- Co-authored-by: Sebastian Jahr <[email protected]> (cherry picked from commit 1944811) Co-authored-by: Aiden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-humble
Mergify label that triggers a PR backport to Humble
backport-iron
Mergify label that triggers a PR backport to Iron
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to resolve missing functionality from Moveit1 which allowed for attached collision objects to become transparent through the setting of an alpha value in
robot_state_visualization.cpp
. It also defaults the alpha value to match the Scene Robot Alpha value which was default behaviour for Moveit1.If this could be backported to Humble it would be much appreciated
Checklist